Cover more sections of the template #17
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting recursive parsing
|
Awesome! |
|
I just bumped a new release: https://github.com/svdgraaf/serverless-pseudo-parameters/releases/tag/v1.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present the plugin only replaces pseudo parameters in the Resources section of the template.
#12 suggests adding support for replacing pseudo parameters in more sections.
This extends the existing recursive parsing of the template to perform replacement across the entire template, thus replacing parameters across all sections.
It is possible this goes too far in replacing the parameters, so it could be revised to only perform replacement in certain sections.
This also adds tests for the Outputs section of the template.