fix(cli): printed args now also display path used during directory prompt #805
Conversation
🦋 Changeset detectedLatest commit: 17c4932 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Pull request overview
This PR fixes a bug where the CLI's argument logging didn't display the directory path when it was entered via the interactive prompt instead of being passed as a command-line argument. The fix ensures that the path is always logged regardless of how it was provided, and maintains consistency by using relative paths unless the user explicitly specifies an absolute path.
- Moved
defaultPathconstant to local scope where it's actually used - Changed directory handling to preserve user input format (relative vs absolute)
- Updated logging to use the actual directory value from prompt group
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/cli/commands/create.ts | Fixed directory path logging by using the directory value from the prompt group instead of the original cwd argument, and moved defaultPath to local scope |
| .changeset/kind-bananas-joke.md | Added changeset documenting the bug fix |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jycouet
deleted the
fix/print-args-dispaly-path-from-input-and-not-absolute
branch
the current implementation never displays the path to the user, if it was not passed as an arg. This fixes the issue.
directorypreviously was an absolute path if the path was specified in the command args, but a relative path if the user entered it via the the prompt. It will now always be a relative one, unless the user specifies an absolute path