Skip to content

Conversation

@sacrosanctic
Copy link
Contributor

Initially brought up in a discord thread.

caused by #695

@changeset-bot
Copy link

changeset-bot bot commented Nov 22, 2025

⚠️ No Changeset found

Latest commit: 5bb0a39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@sacrosanctic sacrosanctic marked this pull request as draft November 22, 2025 17:15
@pkg-pr-new
Copy link

pkg-pr-new bot commented Nov 22, 2025

Open in StackBlitz

npx https://pkg.pr.new/sveltejs/cli/sv@812
npx https://pkg.pr.new/sveltejs/cli/svelte-migrate@812

commit: 5bb0a39

@sacrosanctic
Copy link
Contributor Author

The fix involves repeating logic. Please advice. I don't understand the purpose of virtualWorkspace as it seems to overwrite correct settings.

@jycouet
Copy link
Contributor

jycouet commented Nov 22, 2025

The fix involves repeating logic. Please advice. I don't understand the purpose of virtualWorkspace as it seems to overwrite correct settings.

If you look at the root issue #689 the first part is why we started thinking "virtualWorkspace".
I'll continue your work on the other PR #810
Let's see

@sacrosanctic sacrosanctic marked this pull request as ready for review November 23, 2025 03:42
@sacrosanctic
Copy link
Contributor Author

sacrosanctic commented Nov 23, 2025

I've rebased the changes from #810, the bug still persists.

For now. I've removed the ts check.

This also brings up another issue. create doesn't use svelte.config.ts when typescript is selected. I think it should be addressed in a separate PR.

@manuel3108
Copy link
Member

Thanks for all the research. I've made the diff even smaller by removing the svelte.config.ts fo now, as we never use this. The method where this was happening, is only used during create and not during add so this is fine. I opened #816 for that.

But you brought up a excellent point regarding the dependencyVersion(). We will need to discuss how to handle that!

@manuel3108 manuel3108 merged commit 9f59717 into sveltejs:main Nov 23, 2025
8 checks passed
@sacrosanctic sacrosanctic deleted the fix-ts-detection branch November 23, 2025 07:08
@manuel3108 manuel3108 mentioned this pull request Nov 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants