Shallow routing loses hash fragment

[webJose]

Describe the bug

When goto() is used with an empty string to perform shallow routing, the hash fragment is lost.

Reproduction

Live Repro

In short:

1. Add a hash fragment to the current URL.
2. Call goto('').

Logs

System Info

REPL

Severity

serious, but I can work around it

Additional Information

No response

[PatrickG]

That is how URL behaves, I guess.

const current_url = new URL('https://example.com/path#my-hash');
const next_url = new URL('', current_url);
console.log(next_url.toString()); // 'https://example.com/path'

I'm not sure if sveltekit should do anything about it.

[webJose]

Hello, and thanks for looking into this. Question: What does Sveltekit do with the hash when Sveltekit is in hash routing mode? What happens when users do shallow routing in hash mode?

[PatrickG]

First of all, you're somehow mixing shallow routing with goto.
In sveltekit shallow routing is when you use pushState()/replaceState().
Sveltekit handles the url the same, no matter if you use goto(), pushState() or replaceState(): It uses resolve_url(url) 1 2 3.
Being in hash mode does not change that.

[webJose]

Hello. Yes, I guess I should have started with that.

You see, I'm making my router Sveltekit-compatible so one can do hash routing on top of Sveltekit's path routing. At first, I started with pushState|replaceState, but these don't trigger reactivity on page.url from $app/state, which is fundamental for the router to pick up on URL changes. This is why I moved to goto rather early in the development of the extension package (@wjfe/n-savant-sk).

If pushState|replaceState were to trigger page.url, then I would be using them, and since I am guessing the hash fragment remains with these, I would not be having this issue.

At some point, I suppose I assumed goto would work the same as pushState|replaceState with an empty HREF. So yes, maybe I'm wrong in expecting "shallow routing" from goto, but I'm cornered into using it.

[PatrickG]

and since I am guessing the hash fragment remains with these, I would not be having this issue.

Like I said, pushState()/replaceState() handle the url exactly the same as goto().
Apart from that, shallow routing is probably not the right tool for your use case anyway.

[webJose]

Can you tell me the right tool? AFAICT, only goto() triggers changes in page.url. Is there a better alternative?

[PatrickG]

Yea, goto() is the right tool (and normal <a> tags of course).