Skip to content

fix: preserve this when invoking standard validator #14943

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 20, 2025
+7 −3
Merged

fix: preserve this when invoking standard validator #14943

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
6525f02
keep this bound to validate
thes01 Nov 19, 2025
44bf8b3
changelog
thes01 Nov 19, 2025
c1158ec
Update packages/kit/src/runtime/app/server/remote/shared.js
dummdidumm Nov 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/funny-seas-begin.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: preserve `this` when invoking standard validator
5 changes: 2 additions & 3 deletions packages/kit/src/runtime/app/server/remote/shared.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,9 +30,8 @@ export function create_validator(validate_or_fn, maybe_fn) {
return async (arg) => {
// Get event before async validation to ensure it's available in server environments without AsyncLocalStorage, too
const { event, state } = get_request_store();
const validate = validate_or_fn['~standard'].validate;

const result = await validate(arg);
// access property and call method in one go to preserve potential this context
const result = await validate_or_fn['~standard'].validate(arg);

// if the `issues` field exists, the validation failed
if (result.issues) {
Expand Down
Loading