Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/dull-spies-hammer.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@sveltejs/kit': patch
---

fix: don't use fork of unrelated route
3 changes: 2 additions & 1 deletion packages/kit/src/runtime/client/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -1690,8 +1690,9 @@ async function navigate({
}
}

// also compare ids to avoid using wrong fork (e.g. a new one could've been added while navigating)
const load_cache_fork = intent && load_cache?.id === intent.id ? load_cache.fork : null;
// reset preload synchronously after the history state has been set to avoid race conditions
const load_cache_fork = load_cache?.fork;
load_cache = null;

navigation_result.props.page.state = state;
Expand Down
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<p>slow navigation</p>
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<p>target</p>
15 changes: 15 additions & 0 deletions packages/kit/test/apps/basics/test/client.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -1047,6 +1047,21 @@ test.describe('data-sveltekit attributes', () => {
expect(page).toHaveURL('/data-sveltekit/preload-data/offline/slow-navigation');
});

test('data-sveltekit-preload does not abort ongoing navigation #2', async ({ page }) => {
await page.goto('/data-sveltekit/preload-data/offline');

await page.locator('#slow-navigation').dispatchEvent('click');
await page.waitForTimeout(100); // wait for navigation to start
await page.locator('#one').dispatchEvent('mousemove');
await Promise.all([
page.waitForTimeout(100), // wait for preloading to start
page.waitForLoadState('networkidle') // wait for preloading to finish
]);

expect(page).toHaveURL('/data-sveltekit/preload-data/offline/slow-navigation');
await expect(page.getByText('slow navigation', { exact: true })).toBeVisible();
});

test('data-sveltekit-preload-data tap works after data-sveltekit-preload-code hover', async ({
page
}) => {
Expand Down
Loading