Skip to content

Conversation

@geoffrich
Copy link
Member

@geoffrich geoffrich commented Feb 9, 2022

Fixes #3764
Fixes sveltejs/sites#295

This seemed to happen because we copied styles from svelte.dev's FAQ page, which is white text on black without syntax highlighting.

Before:
image

After:
image

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpx changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

@changeset-bot
Copy link

changeset-bot bot commented Feb 9, 2022

⚠️ No Changeset found

Latest commit: daf592c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@netlify
Copy link

netlify bot commented Feb 9, 2022

✔️ Deploy Preview for kit-demo canceled.

🔨 Explore the source changes: daf592c

🔍 Inspect the deploy log: https://app.netlify.com/sites/kit-demo/deploys/6203ed628e7bfc00085e168a

@benmccann
Copy link
Member

can we also change the svelte.dev FAQ to match? the whole svelte.dev site used to use dark code blocks, but no longer does and it looks like the FAQ wasn't updated when the docs were

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[site] bad contrast in code examples in FAQ [Kit] bad contrast in code examples in FAQ

2 participants