Skip to content

Conversation

@geoffrich
Copy link
Member

Keeping this separate from #8069 since these are smaller fixes instead of a larger design change.

  • remove duplicate text in showcase/deploy links by setting alt="" on the images - e.g. the link was read out as "Vercel logo Vercel" or "Screenshot of pudding.cool pudding.cool", now it's simply "Vercel" and "pudding.cool"
  • make banner a (resolves "all page content must be contained by landmarks warnings")
  • move skip link in front of banner - it was almost entirely obscured
  • treat focusing deployment links the same as hovering them (i.e. color in logo and change text color)
  • label search input
  • make CTRL+K a div instead of a label - it doesn't really work as a label to the search input. I considered linking it to the input with aria-describedby but that didn't feel correct.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. All changesets should be patch until SvelteKit 1.0

- duplicate text in showcase/deploy links
- make banner a <header>
- move skip link in front of banner
- treat focusing deployment links the same as hovering them
- properly label search input
- make CTRL+K a div instead of a label
@changeset-bot
Copy link

changeset-bot bot commented Dec 11, 2022

⚠️ No Changeset found

Latest commit: 86b3e84

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris Rich-Harris merged commit ab5f1c1 into master Dec 12, 2022
@Rich-Harris Rich-Harris deleted the grich/site-a11y branch December 12, 2022 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants