fix: shorthand transition and animation params #816
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Real fix for #785
I've updated the REPL to make it extra clear what is happening.
This demonstrates that unlike the
useshorthand, the transition and animate shorthand pass an empty object as parameter.<div transition:fade>is identical to<div transition:fade={{}}>as far as the svelte compiler is concerned.This allows custom transitions like svelte-transitions-fade-scale:
to work as shorthand
<div transition:fadeScale>without causingCannot read property 'duration' of undefinederrors.In svelte 3.32.0 the params got an empty object as default value
= {}, this change hides the fact that svelte2tsx created the wrong type for the built-in transitions, silencing the "Expected 2 arguments, but got 1." error reported by svelte-check(This is still a nice change, it makes reusing the built-in transitions with defaults easier)