fix: prevent crash in moduleResolution Node16+ #2230
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
approved these changes
Dec 13, 2023
Member
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
Great findings, thank you!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1965 #2228
Patching the
releaseDocumentmethods ofDocumentRegistryso it doesn't error. From my understanding, TypeScript doesn't use theimpliedNodeFormatinside theDocumentRegistry. It'll always be treated as undefined for the svelte files. So, patching thereleaseDocumentpart should be enough.While we were here, I also changed to reuse the
documentRegistryacross language services. It should reduce some memory usage for files reused across language services. While checking if we can optimize the restart as well, I found that TypesScript added the support forscriptKindchanges three years ago. So we no longer need to restart it because ofscriptKindchanges.