Skip to content

fix: watch package.json in more situations #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 15, 2024
Merged

fix: watch package.json in more situations #2332

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions packages/language-server/src/plugins/typescript/module-loader.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,6 +91,8 @@ class ModuleResolutionCache {
class ImpliedNodeFormatResolver {
private alreadyResolved = new FileMap<ReturnType<typeof ts.getModeForResolutionAtIndex>>();

constructor(private readonly tsSystem: ts.System) {}

resolve(
importPath: string,
importIdxInFile: number,
Expand Down Expand Up @@ -120,7 +122,7 @@ class ImpliedNodeFormatResolver {
sourceFile.impliedNodeFormat = ts.getImpliedNodeFormatForFile(
toVirtualSvelteFilePath(sourceFile.fileName) as any,
undefined,
ts.sys,
this.tsSystem,
compilerOptions
);
this.alreadyResolved.set(sourceFile.fileName, sourceFile.impliedNodeFormat);
Expand Down Expand Up @@ -186,7 +188,7 @@ export function createSvelteModuleLoader(
ts.ResolvedTypeReferenceDirectiveWithFailedLookupLocations
>();

const impliedNodeFormatResolver = new ImpliedNodeFormatResolver();
const impliedNodeFormatResolver = new ImpliedNodeFormatResolver(tsSystem);
const failedPathToContainingFile = new FileMap<FileSet>();
const failedLocationInvalidated = new FileSet();

Expand Down Expand Up @@ -266,7 +268,7 @@ export function createSvelteModuleLoader(
name,
containingFile,
compilerOptions,
ts.sys,
tsSystem,
tsModuleCache,
undefined,
mode
Expand Down