(fix) awaited type of promise or plain value #439
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When awaiting the value of a type like Promise<string> | null, the type wouldn't match PromiseLike. Hence the awaited value would still be Promise<string> | null and not string | null. Reducing it to one type declaration and using a conditional type to infer the awaited type should do the trick.
Member
|
Makes sense 👍 Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When awaiting the value of a type like Promise | null, the type
wouldn't match PromiseLike. Hence the awaited value would still be
Promise | null and not string | null. Reducing it to one type
declaration and using a conditional type to infer the awaited type
should do the trick.