Skip to content

Slot props reference block level variable #458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 24 commits into from
Aug 25, 2020
Merged

Slot props reference block level variable #458

merged 24 commits into from
Aug 25, 2020

Conversation

@jasonlyu123
Copy link
Member

@jasonlyu123 jasonlyu123 commented Aug 16, 2020 •
edited
Loading

#263
Still to do

  • support component let
  • catch block
  • more test about variable scope
  • more test about if identifier is member access

dummdidumm
dummdidumm reviewed Aug 16, 2020
View reviewed changes
dummdidumm
dummdidumm reviewed Aug 16, 2020
View reviewed changes
dummdidumm
dummdidumm reviewed Aug 16, 2020
View reviewed changes
@dummdidumm
Copy link
Member

dummdidumm commented Aug 16, 2020

Damn, that's fantastic work!

dummdidumm
dummdidumm reviewed Aug 24, 2020
View reviewed changes
dummdidumm
dummdidumm reviewed Aug 24, 2020
View reviewed changes
jasonlyu123 and others added 5 commits August 24, 2020 13:28
@jasonlyu123 @dummdidumm
TemplateScope optional chaining
039e1fb 
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
@jasonlyu123
null check for resolving and getOwner
9f1f871
@jasonlyu123
better typing for ast nodes
54a77dc 
1. extend def from estree and add range to it
2. remove identifier without range, it seems to be an old behaviour
@jasonlyu123
(refactor) move handle scope and resolve to new file
7aa64f6
@jasonlyu123
Merge branch 'slot-props-2' of https://github.com/jasonlyu123/languag…
6473e58 
…e-tools into slot-props-2
@jasonlyu123 jasonlyu123 marked this pull request as ready for review August 24, 2020 09:50
dummdidumm
dummdidumm approved these changes Aug 24, 2020
View reviewed changes
Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome 👍

@jasonlyu123 jasonlyu123 merged commit fd559c5 into sveltejs:master Aug 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jasonlyu123 @dummdidumm