fix comma operator in debug #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonlyu123
requested changes
Jan 8, 2021
Member
jasonlyu123
left a comment
jasonlyu123
left a comment
There was a problem hiding this comment.
Thanks for your contribution. However, we might need a more complex solution on transformation for better sourcemap.
dummdidumm
requested changes
Jan 8, 2021
Member
dummdidumm
left a comment
dummdidumm
left a comment
There was a problem hiding this comment.
Found a bug in combination with $store usage. {@debug $store} is translated to __sveltets_store_get(myfile)}. Notice the missing { at the start. I guess either the remove in debug removes it or the inner store transformation. One way to fix this could be to remove the @debug like it was done before and overwrite only the , inbetween with }{.
Contributor
Author
|
It's related to the MagicString API, I have no idea how to use prepend/append left/right and the docs aren't helping, using prependLeft on both seems to cover the bug you found |
dummdidumm
approved these changes
Jan 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#739