Skip to content

Conversation

@jasonlyu123
Copy link
Member

@jasonlyu123 jasonlyu123 commented Feb 5, 2021

#726
linked editing for element and component tag. Needs editor.linkedEditing to work properly. Without the setting, It does highlight the linked editing ranges with Ctrl+Shift+F2. but it doesn't seem to enable linked editing.

This works unreliably and I can't find out why. The result on our end seems correct. But it just stops working sometimes. And it will work again after restarting the language-server, In the same position. Need more research on the vscode side to see if there's anything we missed or it's a bug on their side.

@nathanblair
Copy link

Glad I'm not crazy and thought html tags inside svelte files should work with linked editing.

I haven't yet had an experience where linked editing does work but I've only been using VS Code with the linked editing enabled for about 20 minutes now.

I'll keep my findings posted here if my experience changes. Thanks for looking into this!.

@jasonlyu123 jasonlyu123 force-pushed the linked-editing-element branch from 1608412 to 0eac45d Compare March 3, 2021 06:24
@jasonlyu123
Copy link
Member Author

I am guessing it's because the request takes too long. The problem usually happens when I switch files and immediately started linked editing. There is usually a lot of processing when opening the file so the request might take longer.
I can see a similar problem when setting the file association to HTML. But didn't see much complaining in the vscode repo. Maybe we can just add it and see the feedback.

@jasonlyu123 jasonlyu123 marked this pull request as ready for review March 3, 2021 07:38
@dummdidumm dummdidumm merged commit ad6322e into sveltejs:master Mar 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants