Skip to content

Conversation

@baseballyama
Copy link
Member

Summary

  • Fixes TypeScript build errors when using Svelte 5.42+ due to the newly required name_loc property
  • Adds name_loc to manually constructed Attribute objects in src/parser/html.ts
  • Adds name_loc to manually constructed SvelteOptionsRaw objects in src/parser/compat.ts
  • Uses type assertions to maintain backward compatibility with older Svelte versions

Test plan

  • Build passes with Svelte 5.41.0 (current version in package.json)
  • Build passes with Svelte 5.45.4 (latest version)
  • All 8581 existing tests pass
  • Snapshot tests updated to include new name_loc property

🤖 Generated with Claude Code

Svelte 5.42+ added a required `name_loc` property to `BaseElement` and
`BaseAttribute` interfaces. This change adds the property to manually
constructed Attribute and SvelteOptionsRaw objects.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@changeset-bot
Copy link

changeset-bot bot commented Dec 3, 2025

⚠️ No Changeset found

Latest commit: 970f35d

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Dec 3, 2025

Try the Instant Preview in Online Playground

ESLint Online Playground

Install the Instant Preview to Your Local

npm i https://pkg.pr.new/svelte-eslint-parser@970f35d

Published Instant Preview Packages:

View Commit

@coveralls
Copy link

Pull Request Test Coverage Report for Build 19898487661

Details

  • 15 of 18 (83.33%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.01%) to 94.707%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/parser/html.ts 6 9 66.67%
Totals Coverage Status
Change from base Build 19895901968: -0.01%
Covered Lines: 10692
Relevant Lines: 11166

💛 - Coveralls

@baseballyama baseballyama deleted the vk/9594-fix-error-with-l branch December 3, 2025 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants