Skip to content

feat: use css media query for default theming #1631

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2025
Merged

feat: use css media query for default theming #1631

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions apps/svelte.dev/src/routes/(authed)/playground/[id]/AppControls.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -294,6 +294,12 @@
.icon:disabled {
color: #ccc;

:root:not(.light) & {
@media (prefers-color-scheme: dark) {
color: #555;
}
}

:root.dark & {
color: #555;
}
Expand Down
17 changes: 17 additions & 0 deletions apps/svelte.dev/src/routes/_home/Hero.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,6 +63,23 @@
radial-gradient(circle at 40% 30%, rgb(235, 243, 249), rgb(214, 222, 228));
}

:root:not(.light) &::before {
@media (prefers-color-scheme: dark) {
background: linear-gradient(to bottom, transparent, var(--sk-bg-1)),
radial-gradient(
64.14% 72.25% at 47.58% 31.75%,
hsl(209deg 6% 47% / 52%) 0%,
hsla(0, 0%, 100%, 0) 100%
),
linear-gradient(
92.4deg,
hsl(210, 7%, 16%) 14.67%,
hsl(0deg 0% 0% / 48%) 54.37%,
hsla(207, 22%, 13%, 0.62) 92.49%
),
linear-gradient(0deg, hsl(204, 38%, 20%), hsl(204, 10%, 90%));
}
}
:root.dark &::before {
background: linear-gradient(to bottom, transparent, var(--sk-bg-1)),
radial-gradient(
Expand Down
5 changes: 5 additions & 0 deletions apps/svelte.dev/src/routes/docs/[topic]/[...path]/+layout.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,11 @@
.toc-container {
background: var(--sk-bg-2);
display: none;
:root:not(.light) & {
@media (prefers-color-scheme: dark) {
background: var(--sk-bg-0);
}
}

:root.dark & {
background: var(--sk-bg-0);
Expand Down
13 changes: 13 additions & 0 deletions apps/svelte.dev/src/routes/packages/PackageCard.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,12 @@

min-height: 16em;

:root:not(.light) & {
@media (prefers-color-scheme: dark) {
background-color: var(--sk-bg-3);
}
}

:root.dark & {
background-color: var(--sk-bg-3);
}
Expand Down Expand Up @@ -233,6 +239,13 @@
width: 3rem;
height: 3rem;

:root:not(.light) &[alt='drizzle logo'],
:root:not(.light) &[alt='paraglide logo'] {
@media (prefers-color-scheme: dark) {
filter: invert(1);
}
}

:root.dark &[alt='drizzle logo'],
:root.dark &[alt='paraglide logo'] {
filter: invert(1);
Expand Down
8 changes: 8 additions & 0 deletions apps/svelte.dev/src/routes/tutorial/[...slug]/Loading.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -181,6 +181,14 @@
height: 10rem;
}

@media (prefers-color-scheme: dark) {
.loading {
--faded: #444;
--progress: #555;
--cutout: var(--sk-bg-2);
}
}

:global(.dark) .loading {
--faded: #444;
--progress: #555;
Expand Down
5 changes: 5 additions & 0 deletions packages/site-kit/src/lib/components/Text.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -299,6 +299,11 @@
&.remove {
--color: rgba(255, 0, 0, 0.1);

:root:not(.light) & {
@media (prefers-color-scheme: dark) {
--color: rgba(255, 0, 0, 0.27);
}
}
:root.dark & {
--color: rgba(255, 0, 0, 0.27);
}
Expand Down
5 changes: 5 additions & 0 deletions packages/site-kit/src/lib/components/ThemeToggle.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,11 @@
.icon {
mask-image: url(icons/theme-dark);
mask-size: 2rem;
:root:not(.light) & {
@media (prefers-color-scheme: dark) {
mask-image: url(icons/theme-light);
}
}

:root.dark & {
mask-image: url(icons/theme-light);
Expand Down
11 changes: 11 additions & 0 deletions packages/site-kit/src/lib/nav/Nav.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -211,6 +211,11 @@ Top navigation bar for the application. It provides a slot for the left side, th
background: linear-gradient(to top, rgba(0, 0, 0, 0.05), transparent);
}

:root:not(.light) & {
@media (prefers-color-scheme: dark) {
background-color: var(--sk-bg-3);
}
}
:root.dark & {
background-color: var(--sk-bg-3);
}
Expand Down Expand Up @@ -342,6 +347,12 @@ Top navigation bar for the application. It provides a slot for the left side, th
auto;
padding: 0 var(--padding-right) 0 calc(var(--sk-page-padding-side) + 0rem);

:root:not(.light) & {
@media (prefers-color-scheme: dark) {
background-image: url(../branding/svelte-dark.svg);
}
}

:root.dark & {
background-image: url(../branding/svelte-dark.svg);
}
Expand Down
38 changes: 38 additions & 0 deletions packages/site-kit/src/lib/styles/tokens/colours.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,44 @@
/* Misc */
--sk-scrollbar: rgba(0, 0, 0, 0.3);
--sk-shadow: drop-shadow(0px 0px 14px rgba(0, 0, 0, 0.1));

&:not(.light) {
@media (prefers-color-scheme: dark) {
color-scheme: dark;

--sk-bg-hue: 220;

/* Foreground colours */
--sk-fg-1: hsl(var(--sk-bg-hue), 2%, 90%);
--sk-fg-2: hsl(var(--sk-bg-hue), 3%, 80%);
--sk-fg-3: hsl(var(--sk-bg-hue), 5%, 65%);
--sk-fg-4: hsl(var(--sk-bg-hue), 5%, 55%);
--sk-fg-accent: hsl(12, 94%, 62%);

/* Background colours */
--sk-bg-0: hsl(var(--sk-bg-hue), 8%, 10%); /* docs sidebar (dark mode only) */
--sk-bg-1: hsl(var(--sk-bg-hue), 10%, 12%);
--sk-bg-2: hsl(var(--sk-bg-hue), 12%, 14%);
--sk-bg-3: hsl(var(--sk-bg-hue), 14%, 16%);
--sk-bg-4: hsl(var(--sk-bg-hue), 15%, 21%);
--sk-bg-accent: hsl(15, 100%, 35%);
--sk-bg-highlight: hsl(60, 100%, 15%);

/* Border colour */
--sk-border: hsl(var(--sk-bg-hue), 15%, 22%);

/* Syntax highlighting */
--shiki-color-text: hsl(45, 7%, 75%);
--shiki-token-comment: hsl(0, 0%, 55%);
--shiki-token-keyword: hsl(204, 88%, 65%);
--shiki-token-function: hsl(19, 67%, 75%);
--shiki-token-string: hsl(41, 37%, 68%);

/* Misc */
--sk-scrollbar: rgba(255, 255, 255, 0.3);
--sk-shadow: drop-shadow(1px 2px 16px rgba(0, 0, 0, 0.5));
}
}
}

:root.dark {
Expand Down
6 changes: 6 additions & 0 deletions packages/site-kit/src/lib/styles/tokens/typography.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,12 @@
}
}

&:not(.light) {
@media (prefers-color-scheme: dark) {
-webkit-font-smoothing: antialiased;
}
}

&.dark {
-webkit-font-smoothing: antialiased;
}
Expand Down
26 changes: 26 additions & 0 deletions packages/site-kit/src/lib/styles/utils/buttons.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,21 @@
--sk-raised-width: 1px 2px 2px 1px;
--sk-raised-active-width: 2px 1px 1px 2px;

&:not(.light) {
@media (prefers-color-scheme: dark) {
--sk-raised-highlight: hsl(var(--sk-bg-hue), 15%, 32%);
--sk-raised-shadow: var(--sk-bg-3);

/* raised buttons */
--sk-raised-color: var(--sk-raised-border) var(--sk-raised-shadow) var(--sk-raised-shadow)
var(--sk-raised-border);
--sk-raised-hover-color: var(--sk-raised-highlight) var(--sk-raised-shadow)
var(--sk-raised-shadow) var(--sk-raised-highlight);
--sk-raised-active-color: var(--sk-raised-shadow) var(--sk-raised-highlight)
var(--sk-raised-highlight) var(--sk-raised-shadow);
}
}

&.dark {
--sk-raised-highlight: hsl(var(--sk-bg-hue), 15%, 32%);
--sk-raised-shadow: var(--sk-bg-3);
Expand Down Expand Up @@ -42,6 +57,17 @@
background: var(--sk-bg-accent);
color: white;

:root:not(.light) & {
@media (prefers-color-scheme: dark) {
--sk-raised-color: hsla(12, 93%, 60%) hsla(12, 93%, 30%) hsla(12, 93%, 30%)
hsla(12, 93%, 60%);
--sk-raised-hover-color: hsla(12, 93%, 65%) hsla(12, 93%, 27%) hsla(12, 93%, 27%)
hsla(12, 93%, 65%);
--sk-raised-active-color: hsla(12, 93%, 25%) hsla(12, 93%, 70%) hsla(12, 93%, 70%)
hsla(12, 93%, 25%);
}
}

:root.dark & {
--sk-raised-color: hsla(12, 93%, 60%) hsla(12, 93%, 30%) hsla(12, 93%, 30%) hsla(12, 93%, 60%);
--sk-raised-hover-color: hsla(12, 93%, 65%) hsla(12, 93%, 27%) hsla(12, 93%, 27%)
Expand Down