chore: cleanup headers, remove obsolete workarounds #311
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#301 wasn't quite finished, this does finalize the work: - ensure cross origin headers are only set on SvelteKit tutorial pages - remove obsolete workarounds for getting cross origin iframes/images/audio/video working
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Rich-Harris
approved these changes
Oct 9, 2024
|
HNNNGGGHHHH there's some header missing on some file for the SvelteKit tutorial still... Update: For some reason the |
|
Thank god this works now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#301 wasn't quite finished, this does finalize the work: