fix: use commit time for cache #312
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mtime is unreliable between systems / reruns closes #307
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Closed
|
mhm so this doesn't seem to work because the commit time doesn't seem to change. Not sure what I did wrong - will continue investigating tomorrow if noone beats me to it. |
Conduitry
reviewed
Oct 9, 2024
|
|
||
| return mtime; | ||
| const file_commit_time = parseInt( | ||
| execSync(`git log -n 1 --pretty=format:%ct -- ${file}`).toString().trim(), |
There was a problem hiding this comment.
This should use execFileSync instead so we can pass an array of args and don't need to worry about escaping things for the shell.
There was a problem hiding this comment.
(Untested.)
Suggested change
| execSync(`git log -n 1 --pretty=format:%ct -- ${file}`).toString().trim(), | |
| execFileSync('git', ['log', '-n', '1', '--pretty=format:%ct', '--', file]).toString().trim(), |
Conduitry
reviewed
Oct 9, 2024
| import { SHIKI_LANGUAGE_MAP, escape, normalizeSlugify, smart_quotes, transform } from './utils'; | ||
| import type { Modules } from './index'; | ||
| import { fileURLToPath } from 'node:url'; | ||
| import { execSync } from 'node:child_process'; |
There was a problem hiding this comment.
Suggested change
| import { execSync } from 'node:child_process'; | |
| import { execFileSync } from 'node:child_process'; |
|
merged #315, closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
mtime is unreliable between systems / reruns
closes #307
(I haven't tested this out yet)