crimson pro font #488
Closed
crimson pro font #488
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
dummdidumm
commented
Oct 21, 2024
Comment on lines
+1
to
+2
| @import '@fontsource/crimson-pro/400.css'; | ||
| @import '@fontsource/crimson-pro/500.css'; |
There was a problem hiding this comment.
why is it using both by the way? isn't one overriding the other?
There was a problem hiding this comment.
That should not be the case, each defines the font files to use for a specific font-weight that may be set for a given element.
Though 500 is an odd choice, normal corresponds to 400 and bold is 700.
Also don't see the weight 500 being used in the codebase.
|
closing before we open the repo so that we don't attract the peanut gallery |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let's see how this looks