Fix: long <code> elements overflow mobile Safari, shows horizontal scroll bar #560
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…roll bar The "Svelte 5 Migration Guide" page, under the "Modern Browser Required" section, there is a list of inline <code> elements (`clientWidth`...) that horizontally overflow on Mobile Safari, causing a horizontal scrollbar to appear. Adding the `line-break` property to the relevant CSS selector is a simple change that fixes the issue and doesn't appear to break any other styling. (Full transparency, I don't have the time to go through every single page to verify this claim 100%)
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Merged
|
Thank you! Unfortunately this seems to have no effect on Chrome. I've opened #577 as a potential alternative to a CSS fix, though it might be too much of an aesthetic downgrade |
|
Closing in favor of #577 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Inside the "Svelte 5 Migration Guide" page, under the "Modern Browser Required" section, there is a list of inline
<code>elements (starting withclientWidth...) that horizontally overflow on Mobile Safari (iOS 18.0.1), causing a horizontal scrollbar to appear.Change summary
Inside the
<Text>component, adding theline-break: normal;property to the relevant CSS selector allows the inline<code>elements to wrap with the text as expected, eliminating the horizontal scroll bar on the page mentioned above.https://developer.mozilla.org/en-US/docs/Web/CSS/line-break
Screenshots
BEFORE:
AFTER: