`CompileWarning` extends `Error`

[Rich-Harris]

Describe the bug

CompileWarning extends Error and I see no reason why it should — it should just be a POJO (maybe with a convenience toString() method). Found this while trying to postMessage a warning from a worker and finding the message got stripped out

Reproduction

later

Logs

No response

System Info

next

Severity

annoyance

[dummdidumm]

We talked about this a while back that error and warning should share the same shape and therefore we could also make them share the same base class. But yes it may make sense to revisit this.

[trueadm]

So are we saying that CompileDiagnostic shouldn't extend Error now? If so, we definitely spoke about this and agreed that we wanted this behaviour.

[Rich-Harris]

I don't recall that conversation, though I did apparently merge #12326. Why would we want warnings to extend Error? The user doesn't need to know the stack, that's just noise. (Honestly this is true for errors as well — how weird would it be if CompileError didn't extend Error?)

[paoloricciuti]

I don't recall that conversation, though I did apparently merge #12326. Why would we want warnings to extend Error? The user doesn't need to know the stack, that's just noise. (Honestly this is true for errors as well — how weird would it be if CompileError didn't extend Error?)

Just found out why we want to extend Error: it's because vite showing the stack during build and vite-plugin-svelte is passing the InternalCompilerError to vite. This is causing #13933 (not the parsing error but the fact that users get no error at build time.