fix: coordinate mount of snippets with await expressions#17021
Merged
Rich-Harris merged 3 commits intomainfrom Oct 24, 2025
Merged
fix: coordinate mount of snippets with await expressions#17021Rich-Harris merged 3 commits intomainfrom
Rich-Harris merged 3 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: d2ab978 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Member
Author
|
the test failures are something to do with custom elements. imagine my shock. |
dummdidumm
approved these changes
Oct 24, 2025
Member
dummdidumm
left a comment
There was a problem hiding this comment.
Nice, this also helps with #16812 a bit (this PR does at least not pop in the inner snippet while the outer is still there)
Member
|
Oh wait this even fixed #16812 completely - it's just that in the reproduction the |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ok so i really borked up the git history in #17020. trying again. though it looks like some of the tests are failing
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint