Skip to content

Conversation

@Rich-Harris
Copy link
Member

ok so i really borked up the git history in #17020. trying again. though it looks like some of the tests are failing

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2025

🦋 Changeset detected

Latest commit: d2ab978

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@17021

@Rich-Harris
Copy link
Member Author

the test failures are something to do with custom elements. imagine my shock.

Copy link
Member

@dummdidumm dummdidumm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Rich-Harris Rich-Harris merged commit 2e1dd48 into main Oct 24, 2025
18 checks passed
@Rich-Harris Rich-Harris deleted the coordinate-snippet-mount branch October 24, 2025 14:29
@github-actions github-actions bot mentioned this pull request Oct 23, 2025
@dummdidumm
Copy link
Member

Oh wait this even fixed #16812 completely - it's just that in the reproduction the {@const ... } is turned into a blocking await and therefore both run at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants