Skip to content

Conversation

@Rich-Harris
Copy link
Member

a small fix that will be helpful in some upcoming work. If you have something like this...

{await x(async () => await y)}

...then today we generate this...

$.template_effect(($0) => $.set_text(text, $0), void 0, [async () => await x(async () => await y)]);

...when in fact we only need this, because the inner await is inside a function boundary:

$.template_effect(($0) => $.set_text(text, $0), void 0, [() => x(async () => await y)]);

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@changeset-bot
Copy link

changeset-bot bot commented Oct 24, 2025

🦋 Changeset detected

Latest commit: d178106

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
svelte Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

Playground

pnpm add https://pkg.pr.new/svelte@17025

@Rich-Harris Rich-Harris merged commit f45d9cf into main Oct 24, 2025
18 checks passed
@Rich-Harris Rich-Harris deleted the has-await-expression branch October 24, 2025 14:29
@github-actions github-actions bot mentioned this pull request Oct 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants