fix: ignore fork discard() after commit()
#17034
Merged
+24
−11
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
small tweak that fixes a gotcha I just encountered working with forks — if you call
discard()on a fork that has already been committed (e.g.forks.forEach((f) => f.discard()), without removing the just-committed fork fromforks) it will destroy any effects that are needed when the batch eventually resolvesno test because i am under a lot of time pressure 😬 but i consider a regression unlikely
also turned some lets and consts to vars, as is our wont. i also made double-commits no-ops, just like commit-discard.
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint