-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
fix: overhaul each blocks
#17150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
fix: overhaul each blocks
#17150
Conversation
|
|
As noted in #17126,
eachblocks are a little buggy when there's async stuff involved. #16977 fixed a bunch of stuff around async blocks/branches, but excludedeachblocks because, well, they're complicated. But the time has come to deal with it.As the commit messages suggest this is very WIP — a bunch of tests are failing, and while it fixes part of the problem (item effects and the fallback effect both need to be created immediately inside the
blockeffect, not later uponcommit), it doesn't yet fix the problems relating to overlapping async batches. But I thought I'd open the PR in this unfinished state anyway. Pleasingly, so far it's a net reduction in code and complexity.Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint