Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/sad-forks-go.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'svelte': patch
---

fix: keep deriveds reactive after their original parent effect was destroyed
7 changes: 5 additions & 2 deletions packages/svelte/src/internal/client/reactivity/deriveds.js
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,8 @@ import {
STALE_REACTION,
ASYNC,
WAS_MARKED,
CONNECTED
CONNECTED,
DESTROYED
} from '#client/constants';
import {
active_reaction,
Expand Down Expand Up @@ -296,7 +297,9 @@ function get_derived_parent_effect(derived) {
var parent = derived.parent;
while (parent !== null) {
if ((parent.f & DERIVED) === 0) {
return /** @type {Effect} */ (parent);
// The original parent effect might've been destroyed but the derived
// is used elsewhere now - do not return the destroyed effect in that case
return (parent.f & DESTROYED) === 0 ? /** @type {Effect} */ (parent) : null;
}
parent = parent.parent;
}
Expand Down
27 changes: 27 additions & 0 deletions packages/svelte/tests/signals/test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1391,6 +1391,33 @@ describe('signals', () => {
};
});

test('derived whose original parent effect has been destroyed keeps updating', () => {
return () => {
let count: Source<number>;
let double: Derived<number>;
const destroy = effect_root(() => {
render_effect(() => {
count = state(0);
double = derived(() => $.get(count) * 2);
});
});

flushSync();
assert.equal($.get(double!), 0);

destroy();
flushSync();

set(count!, 1);
flushSync();
assert.equal($.get(double!), 2);

set(count!, 2);
flushSync();
assert.equal($.get(double!), 4);
};
});

test('$effect.root inside deriveds stay alive independently', () => {
const log: any[] = [];
const c = state(0);
Expand Down
Loading