fix: maintain correct linked list of effects when updating each blocks#17191
Merged
Rich-Harris merged 5 commits intomainfrom Nov 18, 2025
Merged
fix: maintain correct linked list of effects when updating each blocks#17191Rich-Harris merged 5 commits intomainfrom
Rich-Harris merged 5 commits intomainfrom
Conversation
🦋 Changeset detectedLatest commit: 216e9cc The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
dummdidumm
approved these changes
Nov 18, 2025
|
|
||
| if (prev) { | ||
| prev.e.next = null; | ||
| } |
Member
There was a problem hiding this comment.
Just for clarification: This now keeps a link to the offscreen effects such that they are still connected precisely because prev.e.next is no longer set to null?
Member
Author
There was a problem hiding this comment.
exactly — all effects are linked whether they're onscreen or offscreen, such that updates correctly flow through to offscreen effects as well as onscreen ones
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #17184 — we now maintain the links between effects correctly (I think/hope) such that we never encounter an infinite loop
Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint