Conversation
🦋 Changeset detectedLatest commit: b769107 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
This fixes #17206 Before: (hovering link causes dev console error) After: (no error, link works as expected) |
|
This fails if you update and then read because there's no chance for |
I feel like we should always update inside forks...we could technically do it, but would that be wasteful and possibly performance problematic? |
|
@dummdidumm last commit fixes your playground while keeping CI green (maybe we should also update the test to include the second write)...but I'm really not convinced it's the right solution...it feels wasteful (but more correct so maybe is fine?) |
dummdidumm
left a comment
There was a problem hiding this comment.
ah yeah that works - made it less expensive and updated the test. Thank you!
Closes #17206
For some reason, despite a situation like this being the input for the second commit in #17163 we still ended up ignoring it.
This fixes it, however it introduces a new
Mapwhich I'm not too happy with...we could maybe do something with the batch itself?Before submitting the PR, please make sure you do the following
feat:,fix:,chore:, ordocs:.packages/svelte/src, add a changeset (npx changeset).Tests and linting
pnpm testand lint the project withpnpm lint