Skip to content

Conversation

@Rich-Harris
Copy link
Member

fixes #6657

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with [feat], [fix], [chore], or [docs].
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with npm test and lint the project with npm run lint

@Conduitry Conduitry merged commit 813096d into master Aug 20, 2021
@Conduitry Conduitry deleted the gh-6657 branch August 20, 2021 16:02
@simeydotme
Copy link
Contributor

This merge regresses a previous fix I submitted for animations happening inside of a scaled parent; #3627

Here's a REPL demonstrating the better flip animation failing to account for the scaled parent.
https://svelte.dev/repl/bc936592fbd24977ac21dce48e3b7e3d?version=3.42.1

The regression breaks in UIs like my scenario where I scale the <main> viewport when opening an option/editor panel.


I will see if I can get the original fix I submitted re-applied to this new flip animation if you like? Or was the regression planned

simeydotme added a commit to simeydotme/svelte that referenced this pull request Jan 30, 2022
- get the scale factor by comparing against node.clientWidth
- divide all the positions/dimensions by the scale to get the correct
deltas

- resolves sveltejs#7205
- fixes regression from sveltejs#6658
simeydotme added a commit to simeydotme/svelte that referenced this pull request Jan 30, 2022
- get the scale factor by comparing against node.clientWidth
- divide all the positions/dimensions by the scale to get the correct
deltas

- resolves sveltejs#7205
- fixes regression from sveltejs#6658
simeydotme added a commit to simeydotme/svelte that referenced this pull request Mar 12, 2022
- get the scale factor by comparing against node.clientWidth
- divide all the positions/dimensions by the scale to get the correct
deltas

- resolves sveltejs#7205
- fixes regression from sveltejs#6658
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Flip animations don't properly account for scale

4 participants