changed: strange way with recursion to simple one using %

Author: Inversion-des

lib/circular_array.rb

@@ -4,11 +4,7 @@ class CircularArray < Array
   VERSION = '0.1.0'
 
   def [](index)
-    result = super
-
-    return result if result
-    return nil if size.zero?
-
-    self[index - size]
+    return nil if empty?
+    super(index % size)
   end
 end

spec/circular_array_spec.rb

@@ -11,10 +11,15 @@
 
       it 'behaives like array' do
         expect(circular_array).to be_kind_of Array
-
+        
+        # this will detect accidentally introduced recursion
+        allow(circular_array).to receive(:[]).and_call_original
+        expect(circular_array).to receive(:[]).exactly(4).times
+        
         expect(circular_array[0]).to eq :a
         expect(circular_array[1]).to eq :b
         expect(circular_array[2]).to eq :c
+        expect(circular_array[10]).to eq :b
       end
 
       it 'endless' do