Skip to content

changed: strange way with recursion to simple one using % #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 23, 2019
Merged

changed: strange way with recursion to simple one using % #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions lib/circular_array.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,11 +4,8 @@ class CircularArray < Array
VERSION = '0.1.0'

def [](index)
result = super
return nil if empty?

return result if result
return nil if size.zero?

self[index - size]
super(index % size)
end
end
8 changes: 8 additions & 0 deletions spec/circular_array_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,6 +35,14 @@
expect(circular_array[17]).to eq :c
expect(circular_array[18]).to eq :a
end

it 'no recursion' do
# this will detect accidentally introduced recursion
allow(circular_array).to receive(:[]).and_call_original
expect(circular_array).to receive(:[]).exactly(2).times
expect(circular_array[1]).to eq :b
expect(circular_array[10]).to eq :b
end
end

context 'empty' do
Expand Down