Test / API cleanup #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arrange tests into testsets. In the process this exposed two scoping issues: * defn produces function expressions which are const bindings at global scope, or named closures in local scope. Document this. * Julia macros are hygenic by default and clojure macros seem to be the opposite. Make it possible to use `esc` in macros, and document+test that we take the Julia convention
These have exactly the same functionality, and the string macro is more convenient.
Collaborator
Author
|
Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I arranged the tests into testsets, and noticed that this exposed some points of confusion regarding differences between clojure and julia. Document that we just do things the julia way.
defmacrobased macros able to use theescfunction for julia-style hygienedefnworks the julia way to define named functions (which may be closures in local scopes).Also remove the
@lispmacro to reduce API surface area. It just does exactly the same thing as@lisp_strbut is less convenient.