Skip to content

Conversation

@pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Aug 6, 2022

The underlying issue is that #166 kicks in even if a user has specified a swagger annotation that sets their own schema.

@pjfanning pjfanning marked this pull request as draft August 6, 2022 12:47
@codecov
Copy link

codecov bot commented Aug 6, 2022

Codecov Report

Merging #168 (6ecb81a) into develop (dd111cb) will increase coverage by 0.39%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop     #168      +/-   ##
===========================================
+ Coverage    82.55%   82.95%   +0.39%     
===========================================
  Files            3        3              
  Lines          172      176       +4     
  Branches        16       10       -6     
===========================================
+ Hits           142      146       +4     
  Misses          30       30              
Impacted Files Coverage Δ
...r/scala/converter/SwaggerScalaModelConverter.scala 81.81% <100.00%> (+0.45%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@pjfanning pjfanning self-assigned this Aug 6, 2022
@pjfanning pjfanning marked this pull request as ready for review August 6, 2022 12:55
@pjfanning pjfanning merged commit 8bdb0ce into develop Aug 6, 2022
@pjfanning pjfanning deleted the issue-with-ignoring-schema-annotation-override branch August 6, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants