Skip to content

Conversation

@SamTheisens
Copy link
Contributor

Prioritize explicitly specified format over the one inferred from the primitive type.

This fixes a regression introduced by the optional primitives fix.

over the one inferred from the primitive type
@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #171 (05c2a4c) into develop (8ea4744) will increase coverage by 4.78%.
The diff coverage is 68.18%.

❗ Current head 05c2a4c differs from pull request most recent head 7c5d8a2. Consider uploading reports for the commit 7c5d8a2 to get more accurate results

@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
+ Coverage    83.51%   88.30%   +4.78%     
===========================================
  Files            3        3              
  Lines          182      171      -11     
  Branches        20       15       -5     
===========================================
- Hits           152      151       -1     
+ Misses          30       20      -10     
Impacted Files Coverage Δ
...r/scala/converter/SwaggerScalaModelConverter.scala 87.17% <61.11%> (+5.36%) ⬆️
...github/swagger/scala/converter/ErasureHelper.scala 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@pjfanning
Copy link
Contributor

Can you undo the commit removing curly braces? I like using them. I also don't think users should change the code style except in dedicated PRs.

in getting a property's class and annotations
@SamTheisens
Copy link
Contributor Author

Can you undo the commit removing curly braces? I like using them. I also don't think users should change the code style except in dedicated PRs.

Yes, done.
Code coverage dropped a little though. But couldn't find any uncovered parts in the code I wrote. So I did this one: 05c2a4c
Not logically related to the PR either, although an improvement I'd say. I can do it on another PR or remove it altogether. Let me know what you want.

Ah, I see now that the project coverage has improved, but patch coverage has decreased. 🤔 Don't think i understand.

@pjfanning pjfanning merged commit ce2878e into swagger-akka-http:develop Aug 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants