perf(perser-adaper-json): fold syntactic analysis phases #407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code of the parser have been consolidate into idiomatic parsing phases: lexical and syntactic analysis. There are two types of syntactic analysis: direct and indirect. Indirect syntactic analysis is refactored and simplified original code which turncs CST into JSON AST and then into ApiDOM. Direct one is a new one which turns CST directly into ApiDOM. Switching syntactic analysis is possible via configuration option. Performance of direct syntactic analysis has been increased by 300% comparsing to original code. Performance of indirect syntactic analysis has been increased by 10% comparing to original code and has been significantly simplified. Closes #406
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code of the parser have been consolidate into idiomatic
parsing phases: lexical and syntactic analysis.
There are two types of syntactic analysis: direct and indirect.
Indirect syntactic analysis is refactored and simplified original code
which turncs CST into JSON AST and then into ApiDOM.
Direct one is a new one which turns CST directly into ApiDOM.
Switching syntactic analysis is possible via configuration option.
Performance of direct syntactic analysis has been increased by
300% comparsing to original code.
Performance of indirect syntactic analysis has been increased by
10% comparing to original code and has been significantly simplified.
Closes #406