fix(deps): add apidom-error package as direct dependency #4154
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leipert
reviewed
Apr 25, 2025
| "dependencies": { | ||
| "@babel/runtime-corejs3": "^7.20.7", | ||
| "@swagger-api/apidom-core": "^1.0.0-alpha.3", | ||
| "@swagger-api/apidom-error": "^1.0.0-alpha.1", |
Contributor
There was a problem hiding this comment.
@char0n Should @swagger-api/apidom-error have be be removed from the optionalDependencies below with this change?
leipert
added a commit
to leipert/apidom
that referenced
this pull request
Apr 28, 2025
In swagger-api#4154 `apidom-error` was added as a direct dependency, but wasn't removed as an optional dependency. Given it is now required directly, let's just drop it from the optional ones.
17 tasks
leipert
added a commit
to leipert/apidom
that referenced
this pull request
Apr 28, 2025
In swagger-api#4154 `apidom-error` was added as a direct dependency, but wasn't removed as an optional or dev dependency. Given it is now required directly, let's just drop it from the optional and the dev lists.
char0n
pushed a commit
that referenced
this pull request
Apr 28, 2025
Some time back `apidom-error` was added as a direct dependency, but wasn't removed as an optional or dev dependency. Given it is now required directly, let's just drop it from the optional and the dev lists. Refs #4154
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.