Skip to content

Conversation

@adamgreenhall
Copy link

@adamgreenhall adamgreenhall commented Dec 24, 2021

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

This PR is to add a missing case for multi (array) properties. For example, in this api:

  /api:
    get:
      parameters:
      - name: ids
        in: query
        required: true
        style: form
        explode: true
        schema:
          type: array
          items:
            minimum: 1
            type: integer

When passed multiple integers (eg [1,2,3,4,5]), the current go code sends off the param value 12345. This PR makes the value 1,2,3,4,5.

@adamgreenhall
Copy link
Author

cc @antihax

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant