-
Notifications
You must be signed in to change notification settings - Fork 6k
Fixed over-quoted examples for string definitions #5778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
eefcdca
Fix issue 5460
JFCote 5d4a1fd
Handling only first and last double quote to support example with dou…
JFCote 341fa15
Fix proposed by @ePaul
JFCote 8ee0e12
Add comments to explain de fixStringModel function. Add an enum model…
JFCote 8809792
Merge branch 'master' into fix-5460
wing328 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
43 changes: 43 additions & 0 deletions
43
samples/server/petstore/java-play-framework/app/apimodels/PetStatus.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,43 @@ | ||
| package apimodels; | ||
|
|
||
| import java.util.Objects; | ||
| import javax.validation.constraints.*; | ||
| import com.fasterxml.jackson.annotation.*; | ||
| import com.fasterxml.jackson.annotation.JsonCreator; | ||
|
|
||
| /** | ||
| * Pet's status | ||
| */ | ||
| public enum PetStatus { | ||
|
|
||
| HEALTHY("Healthy"), | ||
|
|
||
| SICK("Sick"), | ||
|
|
||
| QUARANTINED("Quarantined"), | ||
|
|
||
| INPETSHEAVEN("InPetsHeaven"); | ||
|
|
||
| private String value; | ||
|
|
||
| PetStatus(String value) { | ||
| this.value = value; | ||
| } | ||
|
|
||
| @Override | ||
| @JsonValue | ||
| public String toString() { | ||
| return String.valueOf(value); | ||
| } | ||
|
|
||
| @JsonCreator | ||
| public static PetStatus fromValue(String text) { | ||
| for (PetStatus b : PetStatus.values()) { | ||
| if (String.valueOf(b.value).equals(text)) { | ||
| return b; | ||
| } | ||
| } | ||
| return null; | ||
| } | ||
| } | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JFCote I'll remove this tomorrow add the enum example to https://github.com/swagger-api/swagger-codegen/blob/master/modules/swagger-codegen/src/test/resources/2_0/petstore-with-fake-endpoints-models-for-testing.yaml instead.
When the Play generator, we should consider using petstore-with-fake-endpoints-models-for-testing.yaml, which covers a lot more edge cases.