Skip to content

Conversation

@iamolivinius
Copy link
Contributor

@bbdouglas
@JFCote
@sreeshas
@jfiala
@lukoyanov
@cbornet

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: 3.0.0 branch for changes related to OpenAPI spec 3.0. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

The original method accesses the value of a Map entry, using a key that was retrieved from a keySet iterator. It is more efficient to use an iterator on the entrySet of the map, to avoid the Map.get(key) lookup.

http://findbugs.sourceforge.net/bugDescriptions.html#WMI_WRONG_MAP_ITERATOR

@iamolivinius iamolivinius force-pushed the feature-efficiant-map-iteration branch from 6e661e0 to 1aa4602 Compare December 4, 2017 10:43
@wing328
Copy link
Contributor

wing328 commented Dec 6, 2017

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/swagger-api/swagger-codegen/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/swagger-api/swagger-codegen/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@wing328 wing328 added this to the v2.3.0 milestone Dec 6, 2017
@iamolivinius
Copy link
Contributor Author

@wing328

I added the email address to my gh account.

@wing328
Copy link
Contributor

wing328 commented Dec 7, 2017

@iamolivinius looks good now 👍

@wing328 wing328 merged commit 20f48b0 into swagger-api:master Dec 7, 2017
@wing328 wing328 changed the title Make efficient use of entrySet iterator. [Java][RESTEasy] Make efficient use of entrySet iterator. Dec 7, 2017
Gingonic pushed a commit to wirelane/swagger-codegen that referenced this pull request Dec 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants