Fixed issue 1746 - Api and ApiImplicitParam annotations not read when they are in a parent of the resource class #1747
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a fix for issue #1506. Reader got parameter annotations from a child method, ignoring any on a parent class or interface. This fix will look for annotation on the parent class or interface, if it exists. Credit mohitmutha with the fix. I just implemented it and created the pull request.
… they are in a parent of the resource class Also credit to mohitmutha for finding a solution to a similar problem and captdestrukto to provide a pull request for that one
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes issue 1746.
I changed two lines in Reader.java to support these annotations in interfaces/superclasses and provided two testcases for this.
Also credit to mohitmutha for finding a solution to a similar problem and @captdestrukto to provide a pull request for that one
Please note that my pull request also incorporates the changes proposed by captdestrukto; it is a cumulative pull request :)