#2319 parse @Example from @APiResponse annotations #2323
Conversation
agogs
changed the title
agogs
changed the title
frantuma
left a comment
frantuma
left a comment
There was a problem hiding this comment.
Along inline comments, we would also need to add some related tests. This would indeed introduce example support to response annotation, limited to String types, therefore not fully solving #2319, but probably better than no support. Let me know if you can update PR, and/or any comment.
Also related to #1107 and linked tickets, a full solution
would be similar to the one applied in 2.0 version, probably in scope of #1107 and related.
|
|
||
| Response response = new Response() | ||
| .description(apiResponse.message()).headers(responseHeaders); | ||
| .description(apiResponse.message()).headers(responseHeaders).setExamples(examples); |
There was a problem hiding this comment.
would call response.setExamples() on new line, with no need of modifying setter behaviour in response POJO
| public void setExamples(Map<String, Object> examples) { | ||
| public Response setExamples(Map<String, Object> examples) { | ||
| this.examples = examples; | ||
| return this; |
There was a problem hiding this comment.
we don't want to modify setter behaviour, see also comment above
|
There is already an unit test for this feature at |
|
included and replaced by #2801 |
2 participants
Parse @example nested inside @apiresponse annotation