BUG FIX - Use Reflection extension to capture annotations hidden by an aspect. #2337
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…by an aspect Api's like AspectJ may extend or wrap the method. Therefore it is necessary to use the provided reflection extension to capture these situations across the reader
aspich
changed the title
aspich
changed the title
Contributor
Author
|
adressing issue #2335 |
Contributor
|
@aspich could you provide a unit test? |
aspich
force-pushed
the
master
branch
2 times, most recently
from
1ccaa72 to
ce43dca
Compare
Contributor
Author
|
Hello @pjfanning , these methods are already covered by "ImplicitParametersTest" |
Contributor
Author
|
@webron let me know if you need any further input. |
Contributor
|
@aspich We appreciate the PR, it's just an issue of time to review it. Hopefully not too much longer. |
Contributor
Author
|
guys, I understand we are all busy but it's been nearly an year with this simple small PR open.... is there anything that is blocking it? @webron @pjfanning |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aspect frameworks, like AspectJ, may extend or wrap the method making the annotation not to be retrieved using "method.getAnnotations()" .
Therefore it is necessary to use the provided reflection util to capture these situations all across the reader.
This PR make uniform accross the reader the usage of the reflection util for all "apply*" methods which retrieve Swagger annotations.