Skip to content

feat: fixtures for Swagger Petstore definitions #3347

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Aug 3, 2022
Merged

feat: fixtures for Swagger Petstore definitions #3347

merged 4 commits into from
Aug 3, 2022

Conversation

@tim-lai
Copy link
Contributor

@tim-lai tim-lai commented Aug 3, 2022 •
edited
Loading

Description

  • editor-content-fixtures plugin now includes both Swagger Petstore OAS2.0 and OAS3.0 definitions.
  • topbar plugin now renders Edit menu items for both Swagger Petstore OAS2.0 and OAS3.0 definitions.
  • Swagger Petstore OAS2.0 and OAS3.0 definitions are YAML strings in JS format. e.g. not true .yaml file. This is to avoid needing to fetch external files.
  • reorganized Edit menu list items, where "official" Swagger Petstore and "official" AsyncAPI Streetlights definitions reside in their own distinct grouping.

Motivation and Context

Provide "official" Swagger Petstore OAS2.0 and OAS3.0 definitions. Also note, legacy SwaggerEditor recently changed to Petstore OAS3.0 to its default definition.

How Has This Been Tested?

local

Screenshots (if appropriate):

s-e-pr3347

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@tim-lai tim-lai changed the title Feat/next petstore definitions feat: fixtures for Swagger Petstore definitions Aug 3, 2022
@tim-lai tim-lai merged commit 6a638e7 into next Aug 3, 2022
swagger-bot pushed a commit that referenced this pull request Aug 8, 2022
@semantic-release-bot
chore(release): cut the 5.0.0-alpha.16 release
fdf3833 
# [5.0.0-alpha.16](v5.0.0-alpha.15...v5.0.0-alpha.16) (2022-08-08)

### Bug Fixes

* **top-bar:** fix data handling in importUrl async thunk ([#3325](#3325)) ([1e7b49f](1e7b49f))

### Features

* add valid forward spec version detection ([#3360](#3360)) ([24158d2](24158d2))
* fixtures for Swagger Petstore definitions ([#3347](#3347)) ([6a638e7](6a638e7))
* **test:** e2e for toggle readonly and toggle theme ([#3356](#3356)) ([0008d75](0008d75))
* **test:** migrate `topbar` Jest tests to Cypress ([#3350](#3350)) ([fe87c3e](fe87c3e))
* update apidom to 0.40.x ([a9e55d2](a9e55d2))
@swagger-bot
Copy link
Contributor

swagger-bot commented Aug 8, 2022

🎉 This PR is included in version 5.0.0-alpha.16 🎉

The release is available on:

Your semantic-release bot 📦🚀

@char0n char0n deleted the feat/next-petstore-definitions branch March 7, 2023 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

released on @alpha swagger-editor@next

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@tim-lai @swagger-bot