Maximum call stack exceeded between 2.1.10 and 2.1.11

[djMax]

Same swagger docs in both cases. It has something to do with definitions, as I can fix it by removing them all, but even a single one, seemingly no matter how simple, will fail.

/myproject/node_modules/swagger-client/lib/resolver.js:523
      var o = this.getRefs(item);
                   ^

RangeError: Maximum call stack size exceeded
    at Resolver.getRefs (/myproject/node_modules/swagger-client/lib/resolver.js:523:20)
    at Resolver.getRefs (/myproject/node_modules/swagger-client/lib/resolver.js:523:20)
    at Resolver.getRefs (/myproject/node_modules/swagger-client/lib/resolver.js:523:20)
    at Resolver.getRefs (/myproject/node_modules/swagger-client/lib/resolver.js:523:20)
    at Resolver.getRefs (/myproject/node_modules/swagger-client/lib/resolver.js:523:20)
    at Resolver.getRefs (/myproject/node_modules/swagger-client/lib/resolver.js:523:20)
    at Resolver.getRefs (/myproject/node_modules/swagger-client/lib/resolver.js:523:20)

[fehguy]

Hi, can you please share a spec? We have a lot of tests around this but would like to see what's triggering this issue. FYI we're on 2.1.14 now.

[djMax]

Yeah, that's what's confusing the hell out of us - this was working a week ago, and 2.1.10 is much older. Working on isolating such that we could post some reasonable spec.

[fehguy]

OK happy to help if you can share a definition, even privately. I'm currently working on a release of swagger-js right now, so it could be fast.

[djMax]

{
  "swagger": "2.0",
  "info": {
    "version": "0.0.1"
  },
  "paths": {
    "/token": {
      "post": {
        "description": "Create a token for sensitive payment information"
      }
    }
  },
  "definitions": {
    "Foobar": {
      "type": "object",
      "required": [
        "token"
      ],
      "properties": {
        "token": {
          "type": "string"
        }
      }
    }
  }
}

[djMax]

Here's the other trick - you have to load two swagger docs, of which this should be one.

[fehguy]

Then I don't really understand. Can you explain that more? Perhaps with a test?

[djMax]

@jasisk says it's this line

swagger-js/lib/types/operation.js

Line 150 in edf5882

param.modelSignature = {type: innerType, definitions: this.models};

[jasisk]

I'm actively diagnosing but will try to provide more info and a test case as soon as I can.

[djMax]

Here's the (abridged) way it's loaded:

function loadService(services, name) {
      const client = new Client({
        url,
        spec: require(name),
        usePromise: true,
      });
      services[name] = (await client).apis.default;
}

[djMax]

It has something to do with usePromise

[fehguy]

Can you just update to 2.1.14 or better yet, master? I'm afraid I just don't have enough info to even reproduce this.

[djMax]

It happens there too. We're digging. It seems that the constructor returns a promise in usePromise case? A bit odd... My guess is that's messing with scopes somehow.

[djMax]

Now seems babel-related...

[djMax]

And in the end, it appears to be pg-promise. If I require that, this happens. If not, it doesn't. Yeesh.