Skip to content

Fix empty oAuth2 Bearer token added to req header #1131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 12, 2017
Merged

Fix empty oAuth2 Bearer token added to req header #1131

merged 2 commits into from
Sep 12, 2017

Conversation

@c4milo
Copy link
Contributor

@c4milo c4milo commented Sep 11, 2017 •
edited
Loading

When security definitions are present in the spec and an API call is made without providing an access_token value, the resulting auth2 authorization header is invalid: authorization: Bearer .

This PR makes sure an oauth2 authorization header is added only if access_token has a value.

@webron webron requested a review from shockey September 11, 2017 12:42
@shockey shockey merged commit e8868e8 into swagger-api:master Sep 12, 2017
@shockey
Copy link
Contributor

shockey commented Sep 12, 2017

Thanks, @c4milo!

@c4milo
Copy link
Contributor Author

c4milo commented Sep 13, 2017

You got it! Thanks for reviewing and merging! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@shockey shockey shockey approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@c4milo @shockey