Remove the unnecessary loop of all operations when new one added #1225
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous code was looping through all known operations and update their __originalOperationId and operationId, after each one operation is added to the known list.
This is not only inefficient, but introduces a bug at the following line
Where
operationis the one that just got added andobjis the current operation in the loop.This means for the following spec:
When operationId is not defined for the
getoperation, the __originalOperationId incorrectly gets set to 'myId2' when the post operation got added to the list.Motivation and Context
Fixes #1221
How Has This Been Tested?
Added extra unit test to cover the above scenario
Screenshots (if appropriate):
Types of changes
package.json)Checklist: