fix(resolver): don't attach $$ref meta patches to $ref origin locations #1237
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
$$refmeta patches were being attached to the path referenced by a$refas well as the destination, which was caused by the JSON Patch processor linking the $ref source and destination by referencing the same in-memory Object in both positions. This is bad for two reasons:This PR eliminates this issue by breaking the Object reference between the source and destination.
It also:
fast-json-patch@1.2op: '_get'tofast-json-patch's newgetValueByPointerinterfaceMotivation and Context
How Has This Been Tested?
I updated a handful of unit tests to match the new $$ref implementation.
Types of changes
package.json)Breaking internal API change (requires minor version bump).
Checklist: