Add isFreelyNamed #1240
Merged
Add isFreelyNamed #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trying to fix swagger-api/swagger-ui#4168
freelyNamedKeyParents is private no need to export
Contributor
Author
shockey
suggested changes
Feb 8, 2018
src/specmap/helpers.js
Outdated
| const freelyNamedKeyParents = [ | ||
| 'properties', | ||
| ] | ||
| const freelyNamedStrParents = [ |
Contributor
There was a problem hiding this comment.
We should probably be calling this freelyNamedPaths since these are complete paths, not parent keys (the original sin here is mine)
Contributor
Author
There was a problem hiding this comment.
Done ...
Also look at my question about consolidating some
| } | ||
| }, | ||
| properties: { | ||
| allOf: { |
Contributor
There was a problem hiding this comment.
Would like to see a property named $ref tested as well (new test or added to existing one, i'm not picky!)
Contributor
|
thanks @heldersepu! |
rook2pawn
pushed a commit
to rook2pawn/swagger-js
that referenced
this pull request
Feb 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description / Motivation and Context
Trying to fix swagger-api/swagger-ui#4168
Types of changes
package.json)Checklist: