fix: handle empty servers list in oas3 spec when getting baseUrl (#1307) #1310
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
According to: https://swagger.io/docs/specification/api-host-and-base-path/
If the server block doesn't exist, or is empty then it shall default to '/'
This seems to work for a missing servers block, but not for an empty list.
The old code attempted to access the first element in an array without checking if the list was empty.
This fix ensures that the array is not empty.
Motivation and Context
Fixes #1307
How Has This Been Tested?
I tested that the change fixes the following bug in swagger-ui swagger-api/swagger-ui#4505
I used this spec to trigger the failure.
I also added a new unit test to cover the change.
Screenshots (if appropriate):
n/a
Types of changes
package.json)Checklist: